gpui_web: Support browser paste actions - #62575
Open
Veykril wants to merge 1 commit into
Open
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUI's web backend previously dispatched paste shortcuts through the normal keybinding path before the browser's
pasteevent fired. Because the browser clipboard API is asynchronous,Platform::read_from_clipboardreturnedNone; handling the keydown also prevented the browser from delivering the clipboard data throughClipboardEvent.This change defers recognized browser paste shortcuts until the DOM
pasteevent arrives. It temporarily exposes the event's plain-text clipboard item throughPlatform::read_from_clipboard, replays the original keystroke through GPUI's normal input dispatch, and clears the item afterward. Paste initiated from browser menus uses the platform's standard paste keystroke, while alternate bindings such as Ctrl-Shift-V and Shift-Insert retain their original action dispatch.Release Notes: